feat(tool-learning): TLS support for all 4 adapters#35
Merged
Conversation
Valkey: *tls.Config param on NewPolicyStoreFromAddress NATS: *tls.Config param on NewPublisherFromURL + nats.Secure() S3/MinIO: *tls.Config param on NewAuditStoreFromConfig + http.Transport DuckDB: S3 TLS via s3_use_ssl (custom CA via SSL_CERT_FILE env var) main.go: buildClientTLS() helper reads VALKEY_TLS_*, NATS_TLS_*, S3_CA_PATH env vars. TLS 1.3 minimum, optional mTLS with cert+key. Parity with workspace service TLS implementation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
*tls.Configparameter to all tool-learning service adapters, achieving TLS parity with the workspace service.NewPolicyStoreFromAddress(..., tlsCfg *tls.Config)→redis.Options.TLSConfigNewPublisherFromURL(..., tlsCfg *tls.Config)→nats.Secure(cfg)NewAuditStoreFromConfig(..., tlsCfg *tls.Config)→minio.Options.Transports3_use_ssl(custom CA viaSSL_CERT_FILEenv var)New env vars:
VALKEY_TLS_ENABLED,VALKEY_TLS_CA_PATH,VALKEY_TLS_CERT_PATH,VALKEY_TLS_KEY_PATH,NATS_TLS_MODE,NATS_TLS_CA_PATH,NATS_TLS_CERT_PATH,NATS_TLS_KEY_PATH,S3_CA_PATHTest plan
go build ./...— cleango vet ./...— cleango test ./...— 9 packages passnilTLS (backward compatible)🤖 Generated with Claude Code